Capella decode and fallback to bellatrix #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 65.60% 66.06% +0.46%
==========================================
Files 7 7
Lines 907 1049 +142
==========================================
+ Hits 595 693 +98
- Misses 275 309 +34
- Partials 37 47 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
avalonche
force-pushed
the
capella-getpayload
branch
from
8ce5596
to
8cb9cca
Compare
metachris
approved these changes
Jan 17, 2023
|
lgtm! |
screwyprof
pushed a commit
to screwyprof/mev-boost
that referenced
this pull request
Feb 3, 2023
* Capella decode and fallback to bellatrix * update attestant library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
More context in #411.
As part of #392 this PR attempts to decode the
getPayloadcall with capella types (from attestant) and then decode with bellatrix types (from go-boost-utils) as a fallback.⛱ Motivation and Context
📚 References
waiting on attestantio/go-builder-client#2 as attestant types don't have support for capella yet for relay responses.
✅ I have run these commands
make lintmake test-racego mod tidy